[Config] CMake: Shallow clone when using the git-fetch mechanism#5889
Merged
hugtalbot merged 5 commits intosofa-framework:masterfrom Feb 6, 2026
Merged
[Config] CMake: Shallow clone when using the git-fetch mechanism#5889hugtalbot merged 5 commits intosofa-framework:masterfrom
hugtalbot merged 5 commits intosofa-framework:masterfrom
Conversation
Contributor
|
The ci-dpends-on mechanism uses a commit hash. Could you please add a ci-depends-on to this PR to see if the cloning mechanism still works ? |
Collaborator
|
[ci-depends-on] detected during build #3. To unlock the merge button, you must
|
Contributor
Author
it was already tested for commit hash, some of the dependencies of SofaImGui was using a hash for GIT_TAG (thats how I found the problem) |
bakpaul
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No need to retrieve the full repository on fetching IMO
Example with BeamAdapter:
git clone https://github.com/sofa-framework/BeamAdapter ... Receiving objects: 100% (30388/30388), 44.09 MiB | 2.67 MiB/s, done.git clone https://github.com/sofa-framework/BeamAdapter -depth 1 ... Receiving objects: 100% (248/248), 10.09 MiB | 8.03 MiB/s, done.Some caveats from CMake though : https://gitlab.kitware.com/cmake/cmake/-/issues/17770 , depending if GIT_TAG is a branch, a ref or... a tag (🤪)
NOTE: shallow clone does not work if GIT_TAG is hash SHA reference to a commit so I needed some cmake function to test if the argument is a hash.
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if