[Type] Mat: add unit tests and fix isDiagonal()#5909
Open
fredroy wants to merge 4 commits intosofa-framework:masterfrom
Open
[Type] Mat: add unit tests and fix isDiagonal()#5909fredroy wants to merge 4 commits intosofa-framework:masterfrom
fredroy wants to merge 4 commits intosofa-framework:masterfrom
Conversation
Contributor
|
Wikipedia says: The term diagonal matrix may sometimes refer to a rectangular diagonal matrix, which is an m-by-n matrix with all the entries not of the form di,i being zero. For example: |
alxbilger
approved these changes
Jan 30, 2026
hugtalbot
reviewed
Jan 30, 2026
bakpaul
reviewed
Jan 30, 2026
bakpaul
approved these changes
Feb 4, 2026
fde6c00 to
8d1aab3
Compare
Contributor
Author
|
[ci-build][with-all-tests] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While adding some unit tests, I noticed that isDiagonal was wrong 😑
The problem occurs when i=0 (first row). The loop condition is while
j<i-1but when i=0 it will becomej<std::max<sofa::Size>because i and j are unsigned.The fix is also testing if the matrix is rectangular but not sure if we want that 🤔 (like for determinant?)
[with-all-tests]
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if