Skip to content

[Framework] remove virtual keyword for final classes #5932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
fredroy wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Framework] remove virtual keyword for final classes #5932

fredroy wants to merge 1 commit into from
+49 −49

Conversation

@fredroy
Copy link
Contributor

@fredroy fredroy commented Feb 4, 2026 •
edited
Loading

with clang21, ~4-5k warnings were spammed
warning: virtual method 'blockGet' is inside a 'final' class and can never be overridden [-Wunnecessary-virtual-specifier]

[with-all-tests]

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@fredroy fredroy added pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Feb 4, 2026
@fredroy
Copy link
Contributor Author

fredroy commented Feb 4, 2026

[ci-build][with-all-tests]

@epernod epernod added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Feb 5, 2026
@alxbilger alxbilger force-pushed the fix_warning_final_virtual branch from 48d2309 to ad5014a Compare February 5, 2026 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alxbilger alxbilger alxbilger approved these changes

@epernod epernod epernod approved these changes

@bakpaul bakpaul bakpaul approved these changes

Assignees

No one assigned

Labels

pr: clean Cleaning the code pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status ready Approved a pull-request, ready to be squashed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fredroy @alxbilger @epernod @bakpaul