feat: moved writing to different thread #906
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poneciak57
requested changes
Jan 23, 2026
...udio-api/android/src/main/cpp/audioapi/android/core/utils/ffmpegBackend/FFmpegFileWriter.cpp
Show resolved
Hide resolved
...udio-api/android/src/main/cpp/audioapi/android/core/utils/ffmpegBackend/FFmpegFileWriter.cpp
Show resolved
Hide resolved
Contributor
|
i think this idea might also be aplied here |
maciejmakowski2003
requested changes
Jan 27, 2026
| } | ||
|
|
||
| /// @brief Writes audio data to the currently opened file. | ||
| /// This method should be called only from the audio thread (or audio side-effect thread in the future). |
Collaborator
There was a problem hiding this comment.
update comment
| fileNamePrefix: 'recording_', | ||
| channelCount: 2, | ||
| format: FileFormat.M4A, | ||
| format: FileFormat.Wav, |
Collaborator
There was a problem hiding this comment.
intended change?
Member
There was a problem hiding this comment.
please revert to m4a
Suggested change
| format: FileFormat.Wav, | |
| format: FileFormat.M4A, |
poneciak57
approved these changes
Jan 28, 2026
michalsek
requested changes
Jan 29, 2026
| fileNamePrefix: 'recording_', | ||
| channelCount: 2, | ||
| format: FileFormat.M4A, | ||
| format: FileFormat.Wav, |
Member
There was a problem hiding this comment.
please revert to m4a
Suggested change
| format: FileFormat.Wav, | |
| format: FileFormat.M4A, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes RNAA-385
Introduced changes
Checklist