Input selection + ios BT category fix #926
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalsek
requested review from
Copilot,
maciejmakowski2003,
mdydek and
poneciak57
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds input device selection functionality to the audio API and fixes iOS Bluetooth category naming. The main purpose is to allow users to programmatically select audio input devices (e.g., switching between built-in microphone and Bluetooth devices) in response to issue #734.
Changes:
- Added
setInputDevicemethod to AudioManager for selecting input devices - Renamed iOS option from
allowBluetoothtoallowBluetoothHFPfor correct Bluetooth profile - Added
useAudioInputReact hook for managing input device selection with automatic updates on route changes
Reviewed changes
Copilot reviewed 21 out of 22 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/react-native-audio-api/tsconfig.json | Added module suffixes for better native/web resolution |
| packages/react-native-audio-api/src/web-system/AudioManager.ts | Added setInputDevice mock for web platform |
| packages/react-native-audio-api/src/system/types.ts | Added uid field to AudioDeviceInfo, renamed allowBluetooth to allowBluetoothHFP, added setInputDevice to interface |
| packages/react-native-audio-api/src/system/AudioManager.ts | Implemented setInputDevice method, reordered imports |
| packages/react-native-audio-api/src/specs/NativeAudioAPIModule.web.ts | Added setInputDevice method to web spec |
| packages/react-native-audio-api/src/specs/NativeAudioAPIModule.ts | Added setInputDevice to native spec, added non-null assertion |
| packages/react-native-audio-api/src/index.ts | Exported hooks from package entry point |
| packages/react-native-audio-api/src/hooks/useSystemVolume.ts | Updated import to use AudioManager from api module |
| packages/react-native-audio-api/src/hooks/useAudioInput.ts | New hook for managing audio input device selection |
| packages/react-native-audio-api/src/hooks/index.ts | Created hooks barrel export file |
| packages/react-native-audio-api/src/events/types.ts | Extracted InterruptionType and RouteChangeReason as exported types |
| packages/react-native-audio-api/src/api.ts | Reorganized exports, removed useSystemVolume export |
| packages/react-native-audio-api/ios/audioapi/ios/system/AudioSessionManager.mm | Implemented setInputDevice, added uid to device info, changed allowBluetooth to allowBluetoothHFP |
| packages/react-native-audio-api/ios/audioapi/ios/system/AudioSessionManager.h | Added setInputDevice method declaration |
| packages/react-native-audio-api/ios/audioapi/ios/AudioAPIModule.mm | Exposed setInputDevice to React Native bridge |
| packages/react-native-audio-api/android/src/main/java/com/swmansion/audioapi/system/notification/PlaybackNotificationReceiver.kt | Added blank lines for formatting consistency |
| packages/react-native-audio-api/android/src/main/java/com/swmansion/audioapi/AudioAPIModule.kt | Added setInputDevice stub (no-op pending duplex stream implementation) |
| packages/audiodocs/docs/system/audio-manager.mdx | Updated documentation for renamed Bluetooth option |
| packages/audiodocs/docs/react/select-input.mdx | Added documentation for new useAudioInput hook |
| packages/audiodocs/docs/react/category.json | Created React hooks documentation category |
| apps/fabric-example/ios/Podfile.lock | Updated hermes-engine hash |
| apps/common-app/src/examples/Record/Record.tsx | Added device selection UI, updated to use allowBluetoothHFP |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/react-native-audio-api/android/src/main/java/com/swmansion/audioapi/AudioAPIModule.kt
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #734
Introduced changes
Checklist