Skip to content

refactor: options in cpp side #929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mdydek wants to merge 8 commits into
base: main
Choose a base branch
from
Open

refactor: options in cpp side #929

mdydek wants to merge 8 commits into from

Conversation

@mdydek
Copy link
Contributor

@mdydek mdydek commented Jan 31, 2026 •
edited by maciejmakowski2003
Loading

Closes #

⚠️ Breaking changes ⚠️

Introduced changes

  • Moved default options to cpp in order to be able to initialize shadow node state with appropriate values without calling getters

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added/Conducted relevant tests
  • Performed self-review of the code
  • Updated Web Audio API coverage
  • Added support for web
  • Updated old arch android spec file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@poneciak57 poneciak57 Awaiting requested review from poneciak57

@michalsek michalsek Awaiting requested review from michalsek

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

refactoring

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mdydek @maciejmakowski2003