Skip to content

Conversation

@chmjkb
Copy link
Collaborator

@chmjkb chmjkb commented Jan 24, 2026

Description

Introduces a breaking change?

  • Yes
  • No

Type of change

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Documentation update (improves or adds clarity to existing documentation)
  • Other (chores, tests, code style improvements etc.)

Tested on

  • iOS
  • Android

Testing instructions

Screenshots

Related issues

Checklist

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly
  • My changes generate no new warnings

Additional notes

@msluszniak msluszniak added the bug fix PRs that are fixing bugs label Jan 24, 2026
@msluszniak
Copy link
Member

msluszniak commented Jan 24, 2026

Please add short description what problem this PR is trying to solve (concrete scenario) and how to test if it actually fixes it ;)

@chmjkb chmjkb changed the title fix: ensure controller is ready before calling delete in hooks fix: non-null check before calling nativeModule in OCR controllers Jan 26, 2026
@chmjkb chmjkb merged commit 2d18c89 into main Jan 26, 2026
4 checks passed
@chmjkb chmjkb deleted the @chmjkb/controller-unload-fix branch January 26, 2026 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug fix PRs that are fixing bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants