Skip to content

Conversation

@chmjkb
Copy link
Collaborator

@chmjkb chmjkb commented Jan 26, 2026

Description

Current implementation of the OCR controller looks nearly identical, introducing a lot of code repetition. This PR creates a base class so the logic can be shared between vertical and standard ocr controllers.

Introduces a breaking change?

  • Yes
  • No

Type of change

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Documentation update (improves or adds clarity to existing documentation)
  • Other (chores, tests, code style improvements etc.)

Tested on

  • iOS
  • Android

Testing instructions

Screenshots

Related issues

Checklist

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly
  • My changes generate no new warnings

Additional notes

@chmjkb chmjkb self-assigned this Jan 26, 2026
@chmjkb chmjkb requested a review from benITo47 January 26, 2026 10:33
@chmjkb chmjkb force-pushed the @chmjkb/ocr-refactor branch from 98c78e7 to 3efa1e3 Compare January 26, 2026 12:44
@chmjkb chmjkb merged commit 6f8f085 into main Jan 26, 2026
4 checks passed
@chmjkb chmjkb deleted the @chmjkb/ocr-refactor branch January 26, 2026 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants