Extend #403: Mark xfailing tests, raise errors #421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove duplicate tests of __get_item__ on tuples - This includes test parameters that we decided not to test, as the API doesn't see them as valid (list inputs), although they're supported at runtime. - Related: #403 (comment)
SKernchen
approved these changes
Dec 12, 2025
Contributor
SKernchen
left a comment
SKernchen
left a comment
There was a problem hiding this comment.
Still have to talk about refactoring stuff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
ld_context#403 (comment) (i.e., that_getitem__raises on bad input;PR also merges #420 prematurely to be able to work with the new exception.