Skip to content

Conversation

@atilafassina
Copy link
Member

@atilafassina atilafassina commented Feb 10, 2025

adds tests and changeset, thank you @loetjvr

@changeset-bot
Copy link

changeset-bot bot commented Feb 10, 2025

🦋 Changeset detected

Latest commit: fc697d7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@solidjs/start Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Feb 10, 2025

Deploy Preview for solid-start-landing-page ready!

Name Link
🔨 Latest commit fc697d7
🔍 Latest deploy log https://app.netlify.com/sites/solid-start-landing-page/deploys/67a9f4692c899700083d05ff
😎 Deploy Preview https://deploy-preview-1785--solid-start-landing-page.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 10, 2025

@birkskyum
Copy link
Member

birkskyum commented Feb 10, 2025

If I understand correctly, the change here is that it's now just a 404, but doesn't write that it's because the server function isn't found (unless in development)

@birkskyum birkskyum merged commit cda037b into main Feb 10, 2025
11 checks passed
@birkskyum birkskyum deleted the fix/server-function-not-found branch February 10, 2025 12:51
@atilafassina
Copy link
Member Author

If I understand correctly, the change here is that it's now just a 404, but doesn't write that it's because the server function isn't found (unless in development)

Exactly. This way we don't offer any hints about the system if a resource doesn't exist.
I also add a small test to prevent any regressions in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants