Skip to content

Conversation

@birkskyum
Copy link
Member

@birkskyum birkskyum commented Feb 10, 2025

This PR adopts tailwind 4, with the tried and tested postcss config that we know work.

This is a safe way of doing things, in comparison to using the new tailwind vite plugin:

@changeset-bot
Copy link

changeset-bot bot commented Feb 10, 2025

⚠️ No Changeset found

Latest commit: 0445820

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Feb 10, 2025

Deploy Preview for solid-start-landing-page ready!

Name Link
🔨 Latest commit 0445820
🔍 Latest deploy log https://app.netlify.com/sites/solid-start-landing-page/deploys/67a9fe6de9a1660009a84361
😎 Deploy Preview https://deploy-preview-1787--solid-start-landing-page.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 10, 2025

@birkskyum birkskyum changed the title Update tailwind example to v4 chore: update tailwind example to v4 Feb 10, 2025
@atilafassina atilafassina merged commit 2c4e0f0 into solidjs:main Feb 10, 2025
12 of 13 checks passed
@DaniGuardiola
Copy link

Hi @birkskyum thank you.

A few observations:

  • The bug originally preventing the vite plugin from working has been fixed.
  • The other bug causing & to be wrongly processed is NOT related to vite, it happens independently of whether vite or postcss is used.
  • The postcss method is outdated and no longer the main recommended approach (vite is instead). It's probably slower too.
  • I think the example should be updated to the vite setup since the only actual vite-related bug was solved. The other issue should be fixed independently.
  • In fact, I think the Tailwind example should be reverted to v3 for now, as it is currently broken and new users will get a broken starting boilerplate. Then, once fixed, it should be updated to the recommended vite setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants