Skip to content

Conversation

@Brendonovich
Copy link
Collaborator

Start will build to dist by default, which is then overwritten by Nitro v2's netlify preset. This PR overrides Start's build location to .solid-start specifically if preset: "netlify" is set, so that it doesn't overlap with dist. This isn't a problem with Nitro v3 or the Netlify vite plugin (if following their Tanstack Start setup instructions)

@changeset-bot
Copy link

changeset-bot bot commented Nov 23, 2025

⚠️ No Changeset found

Latest commit: 4450980

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Nov 23, 2025

Deploy Preview for solid-start-landing-page ready!

Name Link
🔨 Latest commit 4450980
🔍 Latest deploy log https://app.netlify.com/projects/solid-start-landing-page/deploys/6922885a10b629000820c493
😎 Deploy Preview https://deploy-preview-2010--solid-start-landing-page.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 23, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@solidjs/start@2010

commit: 4450980

@atilafassina atilafassina merged commit fc91e60 into main Nov 23, 2025
9 checks passed
@atilafassina atilafassina deleted the nitro-v2-netlify branch November 23, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants