-
Notifications
You must be signed in to change notification settings - Fork 405
Write event.response.headers to returned Responses #2011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
✅ Deploy Preview for solid-start-landing-page ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
commit: |
6113e0a to
8992c20
Compare
|
doesn't h3 v2 already do this? |
|
@huseeiin Not in 100% of cases |
If a Response is returned from an API route or server function, any headers written via
@solidjs/start/httpincludinguseSessionare not passed on. This writes headers fromgetRequestEvent().responseto the returned response, if the header doesn't already exist on the returned response.In the case of redirects being returned, we clone the response in case it is immutable (such as those returned from
Response.redirect)