Skip to content

Conversation

@Brendonovich
Copy link
Collaborator

If a Response is returned from an API route or server function, any headers written via @solidjs/start/http including useSession are not passed on. This writes headers from getRequestEvent().response to the returned response, if the header doesn't already exist on the returned response.
In the case of redirects being returned, we clone the response in case it is immutable (such as those returned from Response.redirect)

@changeset-bot
Copy link

changeset-bot bot commented Nov 23, 2025

⚠️ No Changeset found

Latest commit: 6eab482

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Nov 23, 2025

Deploy Preview for solid-start-landing-page ready!

Name Link
🔨 Latest commit 6eab482
🔍 Latest deploy log https://app.netlify.com/projects/solid-start-landing-page/deploys/6922e4821cc8ce00082f97b4
😎 Deploy Preview https://deploy-preview-2011--solid-start-landing-page.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 23, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@solidjs/start@2011

commit: 6eab482

@Brendonovich Brendonovich force-pushed the combine-api-route-headers branch from 6113e0a to 8992c20 Compare November 23, 2025 09:22
@Brendonovich Brendonovich merged commit 3643ff3 into main Nov 23, 2025
9 checks passed
@Brendonovich Brendonovich deleted the combine-api-route-headers branch November 23, 2025 10:47
@huseeiin
Copy link
Contributor

doesn't h3 v2 already do this?

@Brendonovich
Copy link
Collaborator Author

@huseeiin Not in 100% of cases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants