Skip to content

Conversation

@Brendonovich
Copy link
Collaborator

@Brendonovich Brendonovich commented Nov 23, 2025

SERVER_BASE_URL was used with Vinxi, now we just rely on Vite's base config which is accessible via env.BASE_URL.

This only makes Start work properly, extra work is currently needed by the end user to make Router work:

<Router base={import.meta.env.BASE_URL} actionBase={`${import.meta.env.BASE_URL}/_server`}>

@changeset-bot
Copy link

changeset-bot bot commented Nov 23, 2025

⚠️ No Changeset found

Latest commit: 7bf97ef

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Nov 23, 2025

Deploy Preview for solid-start-landing-page ready!

Name Link
🔨 Latest commit 7bf97ef
🔍 Latest deploy log https://app.netlify.com/projects/solid-start-landing-page/deploys/6922d22ed5777b00088ed77e
😎 Deploy Preview https://deploy-preview-2012--solid-start-landing-page.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 23, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@solidjs/start@2012

commit: 7bf97ef

@Brendonovich Brendonovich merged commit 139defd into main Nov 23, 2025
9 checks passed
@Brendonovich Brendonovich deleted the vite-base-url branch November 23, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants