Skip to content

Handle base url in api routes #2029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Brendonovich merged 4 commits into from
Dec 13, 2025
Merged

Handle base url in api routes #2029

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5003ce6
handle base url in api routes
Brendonovich Dec 11, 2025
57aeb22
Create nasty-ladybugs-trade.md
Brendonovich Dec 11, 2025
cdf4fcf
Merge branch 'main' into base-url-api-routes
Brendonovich Dec 13, 2025
6edeca8
Merge branch 'main' into base-url-api-routes
Brendonovich Dec 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/nasty-ladybugs-trade.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@solidjs/start": patch
---

Handle base url in api routes
10 changes: 7 additions & 3 deletions packages/start/src/server/handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,9 @@ export function createBaseHandler(
handler: decorateHandler(async (e: H3Event) => {
const event = getRequestEvent()!;
const url = new URL(event.request.url);
const pathname = url.pathname;
const pathname = stripBaseUrl(url.pathname);

const serverFunctionTest = join(import.meta.env.BASE_URL, SERVER_FN_BASE);
if (pathname.startsWith(serverFunctionTest)) {
if (pathname.startsWith(SERVER_FN_BASE)) {
const serverFnResponse = await handleServerFunction(e);

if (serverFnResponse instanceof Response)
Expand Down Expand Up @@ -265,3 +264,8 @@ function produceResponseWithEventHeaders(res: Response) {

return ret
}

function stripBaseUrl(path: string) {
if(import.meta.env.BASE_URL === "/" || import.meta.env.BASE_URL === "") return path;
return path.slice(import.meta.env.BASE_URL.length);
}
Loading