dev: add warning when context is undefined#2466
Open
Tommypop2 wants to merge 2 commits intosolidjs:mainfrom
Open
dev: add warning when context is undefined#2466Tommypop2 wants to merge 2 commits intosolidjs:mainfrom
Tommypop2 wants to merge 2 commits intosolidjs:mainfrom
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Using
useContextoutside of a provider can cause unforeseen and cryptic errors. This PR adds a warning (in dev) when the result ofuseContextis falsy.See https://discord.com/channels/722131463138705510/1358899310116213008
Typescript does protect against using an undefined context somewhat, but I thought a warning could be nice, especially for new users.
How did you test this change?
Created a project and consumed a context without being in its provider:

Warning is printed to the console.
After the project has been built, the warning is not logged.