Use GitHub Action to test extension #321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now possible with the GitHub action
There's not much difference to the main branch anyways.
People might have other authentication solutions, and we can simply not load solidus_auth_devise in specs.
We're expecting the install generator of this gem to change things in the starter frontend, but the generated Dummy app runs on the legacy frontend. This fails, migrations don't run, and all tests fail. This is not the cleanest solution: Ideally we'd have an install generator for dummy apps that works with the starter frontend template, but we're not there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Uses GitHub actions to test this extension, removes some fixes, and simplifies the Gemfile.
Supersedes #320
Checklist
The following are mandatory for all PRs:
The following are not always needed: