feat(entity-archival): add package for entity level archival by yeshamavani · Pull Request #2137 · sourcefuse/loopback4-microservice-catalog

yeshamavani · 2024-07-26T10:57:27Z

gh-1778

Description

Added a new package for entity level archival

Provides a repository mixin to export data to external system and delete the data
A service function that asynchronously imports the data from external system and provides the json data
A default implementation for S3 as external system to archive data.

Fixes #1778

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Intermediate change (work in progress)

Checklist:

Performed a self-review of my own code
npm test passes on your machine
New tests added or existing tests modified to cover all changes
Code conforms with the style guide
API Documentation in code was updated
Any dependent changes have been merged and published in downstream modules

sonarqubecloud · 2024-07-26T13:10:09Z

Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
No data about Coverage
0.3% Duplication on New Code

See analysis details on SonarCloud

samarpan-b · 2024-08-26T08:36:50Z

packages/archival/src/component.ts

+    private options: ArchivalComponentOptions = DEFAULT_ARCHIVAL_OPTIONS,
+  ) {
+    this.providers = {};
+    this.application.component(CoreComponent);


why do we have this dependency ?

when we move this to soft-delete this will no longer be required as I needed this to check if the repo is using DefaultCRUD by loopback or DefaultSoftDelete by ARC since the 'delete' methods are different for both

samarpan-b · 2024-08-26T08:42:13Z

packages/archival/README.md

after reading this, I feel this should be part of soft delete package

will move once the changes are approved as there are comments to be resolved

packages/archival/src/models/job-details.model.ts

packages/archival/src/providers/get-job-details.provider.ts

packages/archival/src/providers/process-import-data.provider.ts

samarpan-b · 2024-08-26T10:01:11Z

packages/archival/src/services/import-archived-data.service.ts

Entire flow for retrieval should be in this service file

samarpan-b · 2024-08-26T10:04:30Z

packages/archival/src/services/import-archived-data.service.ts

+      data.push(...fileContent);
+    }
+
+    const dsName = 'db';


refactor this code. ensure connection is closed gracefully

gh-1778

sonarqubecloud · 2024-12-10T09:29:22Z

Quality Gate failed

Failed conditions
3 New issues

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

yeshamavani requested a review from a team as a code owner July 26, 2024 10:57