Upgrade Core to 421f999a9c14c33233db481f8caa2e062147873e#903
Conversation
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
🤖 Augment PR SummarySummary: This PR upgrades the vendored Changes:
Technical Notes: 🤖 Was this summary useful? React with 👍 or 👎 |
| callback(entry_pointer, rule->name(), rule->message(), outcome); | ||
| continue; | ||
| } | ||
| rule->transform(current, outcome); |
There was a problem hiding this comment.
SchemaTransformer::apply no longer catches SchemaAbortError, but SchemaTransformRule::transform still throws by default; this means a misclassified/partial rule (or a rule that intentionally aborts) will now throw out of apply instead of reporting via callback/result.first. Is this exception-propagation change intended for callers of apply?
🤖 Was this useful? React with 👍 or 👎
|
|
||
| /// The rule transformation. If this virtual method is not overriden, | ||
| /// then the rule condition is considered to not be fixable. | ||
| /// then the rule is considered to not mutate the schema. |
There was a problem hiding this comment.
The comment says that if transform isn’t overridden the rule is “considered to not mutate the schema”, but the default SchemaTransformRule::transform implementation still throws SchemaAbortError. This seems like a contract/docs mismatch that could confuse implementers of new rules.
🤖 Was this useful? React with 👍 or 👎
Signed-off-by: Juan Cruz Viotti jv@jviotti.com