Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DEPENDENCIES
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
vendorpull https://github.com/sourcemeta/vendorpull 1dcbac42809cf87cb5b045106b863e17ad84ba02
core https://github.com/sourcemeta/core 4e9d280a8a452885c7cd2bc488799a4f6410f4d8
core https://github.com/sourcemeta/core fe450b982907f99e542a0cfc78bc60d2b600ff7a
bootstrap https://github.com/twbs/bootstrap 1a6fdfae6be09b09eaced8f0e442ca6f7680a61e
8 changes: 3 additions & 5 deletions src/compiler/compiler.cc
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,9 @@
static auto
transformer_callback_noop(const sourcemeta::core::Pointer &,
const std::string_view, const std::string_view,
const sourcemeta::core::SchemaTransformRule::Result &)
-> void {
// This callback should never be called, as all the transformation rules
// we define in this project can indeed be transformed
assert(false);
const sourcemeta::core::SchemaTransformRule::Result &,
[[maybe_unused]] const bool applied) -> void {
assert(applied);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SchemaTransformer::apply() can still call the callback for the final non-mutating rules pass (with the boolean argument set to false), so assert(applied) could trip in debug builds even though this is meant to be a no-op callback.

Severity: medium

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

}

namespace sourcemeta::jsonbinpack {
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

85 changes: 57 additions & 28 deletions vendor/core/src/core/jsonschema/frame.cc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

58 changes: 42 additions & 16 deletions vendor/core/src/core/jsonschema/jsonschema.cc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion vendor/core/src/core/jsonschema/transformer.cc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.