-
-
Notifications
You must be signed in to change notification settings - Fork 7
metaschema tab entries chain ui #158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
RitoG09
wants to merge
3
commits into
sourcemeta:main
Choose a base branch
from
RitoG09:fix/#150
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,122 @@ | ||
| import { useState } from "react"; | ||
| import type { MetaschemaError,Position } from "../../../protocol/cli"; | ||
| import { goToPosition } from "../message"; | ||
|
|
||
| interface Props { | ||
| errors: MetaschemaError[]; | ||
| } | ||
|
|
||
| function ErrorBox({ | ||
| error, | ||
| size, | ||
| indent | ||
| }: { | ||
| error: MetaschemaError; | ||
| size?: 'primary' | 'stack'; | ||
| indent: number; | ||
| }) { | ||
| const clickable = Boolean(error.instancePosition); | ||
|
|
||
| return ( | ||
| <div | ||
| className={` | ||
| bg-(--vscode-selection) | ||
| border-l-[3px] | ||
| rounded | ||
| p-3 | ||
| transition-colors | ||
| w-full | ||
| max-w-full | ||
| ${clickable ? "cursor-pointer hover:bg-(--vscode-hover)" : ""} | ||
| `} | ||
| style={{ | ||
| marginLeft: indent, | ||
| borderLeftColor: "var(--error)" | ||
| }} | ||
| onClick={() => | ||
| clickable && goToPosition(error.instancePosition as Position) | ||
| } | ||
| > | ||
| <div className="flex items-start gap-2"> | ||
| {size === 'stack' && ( | ||
| <span className="text-(--vscode-muted) font-mono select-none">↳</span> | ||
| )} | ||
| <div className="flex-1"> | ||
| <div className={`text-(--vscode-fg) ${size === 'primary' ? 'text-[14px] font-semibold' : 'text-[12px]'}`}> | ||
| {error.error} | ||
| </div> | ||
| {error.instanceLocation && ( | ||
| <div className="mt-1 text-[11px] text-(--vscode-muted) break-all"> | ||
| {error.instanceLocation || "(root)"} | ||
| </div> | ||
| )} | ||
| </div> | ||
| </div> | ||
| </div> | ||
| ); | ||
| } | ||
|
|
||
|
|
||
| export function MetaschemaStackTrace({errors}:Props){ | ||
| const [expanded,setExpanded]= useState(false); | ||
|
|
||
| if(errors.length===0) return null; | ||
|
|
||
| const [primary, ...stack] = errors; | ||
|
|
||
| if (!primary) return null; | ||
|
|
||
| return ( | ||
| <div className="flex flex-col gap-3"> | ||
| {/* Top level error */} | ||
| <ErrorBox | ||
| error={primary} | ||
| size="primary" | ||
| indent={0} | ||
| /> | ||
|
|
||
| {stack.length > 0 && ( | ||
| <button | ||
| className="flex items-center gap-1.5 cursor-pointer py-2 select-none hover:opacity-80" | ||
| onClick={() => setExpanded(!expanded)} | ||
| > | ||
| <span | ||
| className="text-(--vscode-muted) text-[10px] transition-transform duration-200" | ||
| style={{ transform: expanded ? 'rotate(90deg)' : 'rotate(0deg)' }} | ||
| > | ||
| ▶ | ||
| </span> | ||
| {expanded ? 'Hide stack trace' : 'Show stack trace'} | ||
| </button> | ||
| )} | ||
|
|
||
| {/* Stack trace */} | ||
| <div className="w-full"> | ||
| <div className={`overflow-hidden transition-all duration-300 ease-in-out ${expanded ? "max-h-[2000px] opacity-100" : "max-h-0 opacity-0"}`}> | ||
| <div className="flex flex-col gap-2 mt-2"> | ||
| { | ||
| stack.map((err,ind)=>{ | ||
| const STACK_INDENT = 16; | ||
| return ( | ||
| <div | ||
| key={ind} | ||
| className="flex items-start gap-2" | ||
| style={{ paddingLeft: STACK_INDENT }} | ||
| > | ||
| <span className="text-(--vscode-muted) font-mono select-none mt-1">↳</span> | ||
| <ErrorBox | ||
| error={err} | ||
| indent={0} | ||
| /> | ||
| </div> | ||
| ) | ||
| }) | ||
| } | ||
| </div> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| ) | ||
| } | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| export function splitIntoRows<T>( | ||
| items: T[], | ||
| containerWidth: number, | ||
| itemWidth: number, | ||
| gap: number | ||
| ): T[][] { | ||
| const itemsPerRow = Math.max( | ||
| 1, | ||
| Math.floor((containerWidth + gap) / (itemWidth + gap)) | ||
| ); | ||
|
|
||
| const rows: T[][] = []; | ||
| for (let i = 0; i < items.length; i += itemsPerRow) { | ||
| rows.push(items.slice(i, i + itemsPerRow)); | ||
| } | ||
| return rows; | ||
| } | ||
|
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2: The
(root)fallback is unreachable because the block is only rendered wheninstanceLocationis truthy. IfinstanceLocationis empty/undefined, no location is shown. Render the block unconditionally (or explicitly check for null) so the fallback is displayed.Prompt for AI agents