-
Notifications
You must be signed in to change notification settings - Fork 70
Major Refactoring #529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
splitbrain
wants to merge
37
commits into
master
Choose a base branch
from
refactor
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Major Refactoring #529
Changes from 1 commit
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
01d4b86
updated mpdf to 8.2 (requires php 8.0 now)
splitbrain c5c184f
first start at refactoring
splitbrain b883aec
add toc handling
splitbrain 1d334a8
handle debug writing
splitbrain 8c4b141
remove a few now unused methods
splitbrain 081fc33
Handle styles
splitbrain 2bef96e
move page collecting into separate classes
splitbrain ac65d8f
remove some moved methods
splitbrain 6afd336
remove obsolete template event
splitbrain 293d84e
more refactoring
splitbrain 0eefd8f
decouple renderer
splitbrain ab12f14
removed more obsolete methods from action plugin
splitbrain f77f381
fixed issues from first real run
splitbrain decfd8d
extract $INPUT dependencies out of Collector classes
splitbrain 4c3a95e
reimplement ImageProcessor differently
splitbrain 38ca8b2
updated tests for Media resolving
splitbrain c617724
update general test
splitbrain 8f1c137
removed unneeded custom exception
splitbrain bbcdb3f
rewrite internal links. implements #526
splitbrain 4526935
address some of the remaining FIXMEs
splitbrain 5eabda9
fix additional blank page at the end
splitbrain b706c93
fixed remaining sort test
splitbrain 32d393a
have collectors check for page existance
splitbrain b23d7b8
for exporting single pages do not rely on $ID
splitbrain 9220075
Added tests
splitbrain 5340eaf
rector and codesnifffer fixes
splitbrain fbe4e9d
remove obsolete book chapter handling in action
splitbrain 7002812
extracted PDF generation and sending out of action
splitbrain 7542e5b
some minor fixes based on PR feedback
splitbrain 01a7083
Use attributes in config class to denote how to initialize them
splitbrain f200011
make PdfExportService reusable in debug mode
splitbrain a9e9f33
introduce a first test for rendering - testing numbered headlines
splitbrain bee95f0
Overhaul chapter/header counting in renderer
splitbrain b08d547
pass the Config object into the renderer
splitbrain c124fc5
Some more tests testing rendering functionality
splitbrain 212a1ea
fix config attrbutes and extend tests
splitbrain 837fcad
update MPDF downgrade log/psr
splitbrain File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.