Http module #831
Http module #831
Conversation
Move HTTP-related code into a standalone Http module for better modularity. This includes HttpClient, request/response types, TLS pinning infrastructure, and endpoint handling. The Split module now imports Http and uses adapter protocols for authentication and notifications. Co-authored-by: Cursor <cursoragent@cursor.com>
SDK Readiness Test Results ✅
Legend: 🟢 significant improvement | 🔴 significant regression | ⚪ inconclusive (p≥0.05) ios-test-mock
|
SDK Readiness Test Results ✅
Legend: 🟢 significant improvement | 🔴 significant regression | ⚪ inconclusive (p≥0.05) ios-test-mock
|
SDK Readiness Test Results ✅
Legend: 🟢 significant improvement | 🔴 significant regression | ⚪ inconclusive (p≥0.05) ios-test-mock
|
SDK Readiness Test Results ✅
Legend: 🟢 significant improvement | 🔴 significant regression | ⚪ inconclusive (p≥0.05) ios-test-mock
|
Tests moved and adapted
README added
| // This is visible for testing purposes, because this logic is simple but has a tricky implementation | ||
| // It is not part of the implemented protocol | ||
| static func spki(from certificate: SecCertificate) -> CertSpki? { | ||
| public static func spki(from certificate: SecCertificate) -> CertSpki? { |
There was a problem hiding this comment.
I guess if we move the mentioned test this could go back to non public. Just a minor comment though.
| import Http | ||
|
|
||
| // Re-export only CertificatePinningStatus for SDK consumers | ||
| @_exported import enum Http.CertificatePinningStatus |
There was a problem hiding this comment.
Double check the @_exported is necessary.
SDK Readiness Test Results ✅
Legend: 🟢 significant improvement | 🔴 significant regression | ⚪ inconclusive (p≥0.05) ios-test-mock
|
|
3 participants
iOS SDK
What did you accomplish?
How do we test the changes introduced in this PR?
Extra Notes