Make removeMessageListener listener parameter non-nullable#3237
Closed
Kiminni wants to merge 1 commit intospring-projects:mainfrom
Closed
Make removeMessageListener listener parameter non-nullable#3237Kiminni wants to merge 1 commit intospring-projects:mainfrom
Kiminni wants to merge 1 commit intospring-projects:mainfrom
Conversation
Signed-off-by: Kiminni <imk0980@gmail.com>
onobc
added a commit
that referenced
this pull request
Feb 3, 2026
- Add integration test to verify all removeMessageListener variants - Add unit tests for negative tests on removeMesssageListener invalid inputs - Clarify javadocs Original Pull Request #3237
tishun
pushed a commit
to tishun/spring-data-redis
that referenced
this pull request
Feb 18, 2026
Closes spring-projects#3237 Signed-off-by: Kiminni <imk0980@gmail.com> Signed-off-by: Tihomir Mateev <tihomir.mateev@redis.com>
tishun
pushed a commit
to tishun/spring-data-redis
that referenced
this pull request
Feb 18, 2026
- Add integration test to verify all removeMessageListener variants - Add unit tests for negative tests on removeMesssageListener invalid inputs - Clarify javadocs Original Pull Request spring-projects#3237 Signed-off-by: Tihomir Mateev <tihomir.mateev@redis.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Changed the
listenerparameter ofremoveMessageListenermethods inRedisMessageListenerContainerto be non-nullable. (issue #3016)Changes
@Nullableannotation fromlistenerparameter inremoveMessageListener(MessageListener, Collection<Topic>)method@Nullableannotation fromlistenerparameter inremoveMessageListener(MessageListener, Topic)method@Nullableannotation fromlistenerparameter in internalremoveListenermethodAssert.notNull(listener, "MessageListener must not be null")validation inremoveListenermethodif (listener != null && ...)condition)