Skip to content

Use String instead of long for JFR event IDs to support JMC filtering. #36077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
youngledo wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −6
Open

Use String instead of long for JFR event IDs to support JMC filtering. #36077

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions ...g-core/src/main/java/org/springframework/core/metrics/jfr/FlightRecorderStartupEvent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,16 +29,19 @@
* as a single {@code String}, since Flight Recorder events do not support complex types.
*
* @author Brian Clozel
* @author Huang Xiao
* @since 5.3
*/
@Category("Spring Application")
@Label("Startup Step")
@Description("Spring Application Startup")
class FlightRecorderStartupEvent extends Event {

public final long eventId;
@Label("EventId")
public final String eventId;

public final long parentId;
@Label("ParentId")
public final String parentId;

@Label("Name")
public final String name;
Expand All @@ -48,8 +51,8 @@ class FlightRecorderStartupEvent extends Event {

public FlightRecorderStartupEvent(long eventId, String name, long parentId) {
this.name = name;
this.eventId = eventId;
this.parentId = parentId;
this.eventId = String.valueOf(eventId);
this.parentId = String.valueOf(parentId);
}

public void setTags(String tags) {
Expand Down
4 changes: 2 additions & 2 deletions ...ng-core/src/main/java/org/springframework/core/metrics/jfr/FlightRecorderStartupStep.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,12 +55,12 @@ public String getName() {

@Override
public long getId() {
return this.event.eventId;
return Long.parseLong(this.event.eventId);
}

@Override
public Long getParentId() {
return this.event.parentId;
return Long.parseLong(this.event.parentId);
}

@Override
Expand Down