Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -83,4 +83,4 @@ that contain a parameter named `siteLanguage` now changes the locale. So, for ex
a request for the URL `https://domain.com/home.view?siteLanguage=nl` changes the site
language to Dutch. The following example shows how to intercept the locale:

include-code::./WebConfiguration[tag=snippet,indent=0]
include-code::./WebConfiguration[tag=snippet,indent=0,chomp=-tags]
8 changes: 4 additions & 4 deletions framework-docs/package.json
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
{
"dependencies": {
"antora": "3.2.0-alpha.4",
"@antora/atlas-extension": "1.0.0-alpha.2",
"@antora/collector-extension": "1.0.0-alpha.3",
"antora": "3.2.0-alpha.11",
"@antora/atlas-extension": "1.0.0-alpha.5",
"@antora/collector-extension": "1.0.2",
"@asciidoctor/tabs": "1.0.0-beta.6",
"@springio/antora-extensions": "1.14.7",
"fast-xml-parser": "4.5.2",
"@springio/asciidoctor-extensions": "1.0.0-alpha.10"
"@springio/asciidoctor-extensions": "1.0.0-alpha.17"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ class WebConfiguration {
setInterceptors(LocaleChangeInterceptor().apply {
paramName = "siteLanguage"
})
/* @chomp:line urlMap = mapOf("/**/*.view" to "someController") */urlMap = mapOf("/**/*.view" to "someController")
urlMap = mapOf("/**/*.view" to "someController")
}
}
// end::snippet[]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1479,11 +1479,8 @@ public static ResolvableType forType(@Nullable Type type) {
* @see #forType(Type)
*/
public static ResolvableType forType(@Nullable Type type, @Nullable ResolvableType owner) {
VariableResolver variableResolver = null;
if (owner != null) {
variableResolver = owner.asVariableResolver();
}
return forType(type, variableResolver);
return (owner == null ? forType(type, null, null) :
forType(type, owner.typeProvider, owner.asVariableResolver()));
}

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1346,6 +1346,7 @@ void narrow() throws Exception {
ResolvableType type = ResolvableType.forField(Fields.class.getField("stringList"));
ResolvableType narrow = ResolvableType.forType(ArrayList.class, type);
assertThat(narrow.getGeneric().resolve()).isEqualTo(String.class);
assertThat(type.getSource()).isSameAs(narrow.getSource());
}

@Test
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -252,10 +252,10 @@ else if (targetClass != null && converter.canRead(targetClass, contentType)) {
protected ResolvableType getNestedTypeIfNeeded(ResolvableType type) {
ResolvableType genericType = type;
if (Optional.class.isAssignableFrom(genericType.toClass())) {
genericType = genericType.getNested(2);
genericType = ResolvableType.forType(genericType.getNested(2).getType(), type);
}
if (HttpEntity.class.isAssignableFrom(genericType.toClass())) {
genericType = genericType.getNested(2);
genericType = ResolvableType.forType(genericType.getNested(2).getType(), type);
}
return genericType;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
import jakarta.servlet.http.HttpServletResponse;
import org.jspecify.annotations.Nullable;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;

import org.springframework.core.MethodParameter;
Expand Down Expand Up @@ -152,7 +151,6 @@ void resolveGenericArgument() throws Exception {
}

@Test
@Disabled("Determine why this fails with JacksonJsonHttpMessageConverter but passes with MappingJackson2HttpMessageConverter")
void resolveArgumentTypeVariable() throws Exception {
Method method = MySimpleParameterizedController.class.getMethod("handleDto", HttpEntity.class);
HandlerMethod handlerMethod = new HandlerMethod(new MySimpleParameterizedController(), method);
Expand Down