Revise nullability in HttpEntity and ResponseEntity #36238
Conversation
Signed-off-by: Tran Ngoc Nhan <ngocnhan.tran1996@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
|
|
||
| private final HttpHeaders headers; | ||
|
|
||
| private final @Nullable T body; |
There was a problem hiding this comment.
Here, you should just leverage the nullability defined at type level, so please remove the explicit @Nullable override here.
There was a problem hiding this comment.
I have removed but the compileJava task build fail
Within @NullMarked, remember, unannotated types are the same as if they were annotated with @nonnull. Since the bound of E is the same as @nonnull Number, and not @nullable Number, that means the type argument for E can't be a type that includes null. @nullable Integer can't be the type argument, then, since that can include null. (In other words: @nullable Integer is not a subtype of Number.)
| * @param headers the entity headers | ||
| * @since 7.0 | ||
| */ | ||
| public HttpEntity(@Nullable T body, @Nullable HttpHeaders headers) { |
There was a problem hiding this comment.
Here, you should just leverage the nullability defined at type level, so please remove the explicit @Nullable override here and in other similar use cases.
sdeleuze
added
the
in: web
sbrannen
changed the title
@Nullable to ResponseEntity generic type4 participants
Based on the IDE warning shown in the screenshot
This change adds
@Nullableto the generic bound of ResponseEntity to make the nullability contract.Related to gh-36236