Fix missing items of collections/array in grouping logic

[Markus-Sky]

Need to also add tests, also maybe i missed anyOf, etc.
Can you give me a hint where and what kind of tests you would like to have for this case?

#1617

[netlify]

✅ Deploy Preview for springwolf-ui canceled.

Name	Link
🔨 Latest commit	136e6fc
🔍 Latest deploy log	https://app.netlify.com/projects/springwolf-ui/deploys/697a70b3c09c3b0008978b34

[timonback]

Hi @Markus-Sky
Thank you for opening a fix right away.

Testing is a good question, as this is not well covered as part of the unit test.

Still, there is an integration test can be used: springwolf-core/src/test/java/io/github/springwolf/core/integrationtests/application/GroupingIntegrationTest.java
At this point it probably makes sense to duplicate the ListenerApplication to GroupingApplication or similar and reproduce your issue with the arraySchema there.

Does this help?

[Markus-Sky]

Hi @Markus-Sky Thank you for opening a fix right away.

Testing is a good question, as this is not well covered as part of the unit test.

Still, there is an integration test can be used: springwolf-core/src/test/java/io/github/springwolf/core/integrationtests/application/GroupingIntegrationTest.java At this point it probably makes sense to duplicate the ListenerApplication to GroupingApplication or similar and reproduce your issue with the arraySchema there.

Does this help?

Yes, i already saw ListenerApplication but also did not want to change that directly. I will go with the separate GroupingApplication.

[timonback]

Hi @Markus-Sky, test code looks good. I made some minor changes for readability.

This will be reviewed on one of the next Fridays, but definitely before the next release.

Thank you for diving in and providing the fix and testing code!

[Markus-Sky]

Hi @Markus-Sky, test code looks good. I made some minor changes for readability.

This will be reviewed on one of the next Fridays, but definitely before the next release.

Thank you for diving in and providing the fix and testing code!

I want a change so why would I not try to help to implement it. Thanks for taking a look.