This repository was archived by the owner on Dec 2, 2020. It is now read-only.
collectd collector should use multiple collections to store data #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
This sounds reasonable. I think if the plugin name is persisted in the collection name, we don't also need the plugin name in the event data, though. |
Author
|
yes, I agree, I can change that too, it's less than a line |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As collectd reports a lot of different kind of data, it would be better to use a collection per type, like it used to be the case in some previous version of cube.
@mbostock should we maintain a fork just for this line ( :-s ), or would you merge it ?