Improve error message when headers exceed 256 KiB limit #9259
+11
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When response headers exceed the 256 KiB limit, the error message was a generic "\\n not found: limit=0" from Okio's readUtf8LineStrict. Now the error message clearly states: "Header line limit exceeded (256 KiB). The response headers are too large." This helps users immediately understand the cause without having to dig into OkHttp internals. Fixes square#9233
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improve the error message when response headers exceed the 256 KiB limit.
Before:
After:
Changes
EOFExceptionfromreadUtf8LineStrictinHeadersReader.readLine()ProtocolExceptionwith a descriptive message that clearly states the causeTest Plan
Fixes #9233