Open
Conversation
Merged
|
|
Armaxis
force-pushed
the
bump_targetSdk_to_34
branch
2 times, most recently
from
2ca29e4 to
851c6a9
Compare
Member
|
Looks like we need to update/upload the provisioning profiles so the github actions can access them. |
updated run script fixing pipelines for ios fixing pipeling for minifyEnable fixing lint error for camera permission in pipelines fixing notification permissions issue in pipelines fixing proguard issue in pipeline
Armaxis
force-pushed
the
bump_targetSdk_to_34
branch
from
851c6a9 to
1f39e5e
Compare
Bump reader sdk version to fetch for ios build and update xcodebuild to not code sign example app
Member
brandonjenniges
left a comment
brandonjenniges
left a comment
There was a problem hiding this comment.
LGTM, I think you just need to update the Changelog with the changes to 4.0.2
brandonjenniges
requested changes
Sep 18, 2024
|
|
||
| ### v4.0.2 Sep 18, 2024 | ||
|
|
||
| * Upgrade to Reader SDK 1.7.7 on Android. |
Member
There was a problem hiding this comment.
Doesn't this version also update to 1.7.4 on iOS?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. changed targetSdk to 342. changed graddle plugin to 8.7 and other dependencies to make the example app run on android
3. updated the dependencies permission_handler, barcode_scan2, firebase_core to make it compatible with SDK 34
4. updated platform :ios to 13.1 in Podfile to run the example of iOS
First three changes has been extracted into a separate PR #117 for android-only changes to support SDK 34.
This PR is now only about the iOS changes