Polish SQUID_CHECK_KRB5_CONTEXT_MEMORY_KEYTAB macro

[yadij]

• trivial whitespace cleanup
• reposition for alphabetical naming order
• move SQUID_DEFINE_BOOL inside the check macro

[yadij]

FTR; these changes have already passed review in PR #1157.

[yadij]

These changes have reached 10+ days without any negative feedback. The merge bot should have committed them already.

[rousskov]

These changes have reached 10+ days without any negative feedback.

Correct.

The merge bot should have committed them already.

Incorrect: The merge bot is correctly waiting for a required status check called "Review" to complete. GtHub clearly shows that some required checks have not been completed:

Some checks haven't completed yet
1 expected, 11 successful checks
1 pending check
Review  Expected — Waiting for status to be reported    Required

I have not checked why this GitHub-managed(?) "Review" status check was added to the set of the required PR checks. GtHub review counting has always been incompatible with how we count votes and should not be enabled. We have discussed that before.

I have not checked, but it is likely that the same recently introduced GitHub configuration(?) problem applies to other recent PRs, including #2316 and #2315.

FWIW, I do not recommend changing GitHub configuration without discussing those changes first.

[rousskov]

The merge bot is correctly waiting for a required status check called "Review" to complete. GtHub clearly shows that some required checks have not been completed:

Some checks haven't completed yet
1 expected, 11 successful checks
1 pending check
Review  Expected — Waiting for status to be reported    Required

I have not checked why this GitHub-managed(?) "Review" status check was added to the set of the required PR checks. GtHub review counting has always been incompatible with how we count votes and should not be enabled. We have discussed that before.

I have now removed that "Review" check from the set of the required PR checks in our master branch configuration on GitHub. I have not investigated when/why it was added. This removal should allow eligible PRs to merge again.

[yadij]

Blocked for 3 weeks by @rousskov because lines of text unrelated to this PR exist in the Squid code.