Bug 5528: tests/testRock fails on Solaris #2324
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with stub time| FATAL: Ipc::Mem::Segment::create failed to
shm_open(squid-0-tr_rebuild_stats.shm): (22) Invalid argument
Instance::NamePrefix() stub implementation ignored `head` and `tail`
arguments, resulting in malformed shared memory segment names on
Solaris. Other tested OSes tolerate the lack of a leading "/" character.
Linux shm_open(3) recommends "/somename" format "for portable use".
Simply adding `head` and `tail` to `NamePrefix()` result fixes tests on
Solaris but breaks tests on MacOS. We shortened the result (by removing
pid_filename hash component mimicking) to avoid that breakage and
detailed the problem in a C++ comment. More work is needed to replace
human-friendly name components with hashes [on MacOS].
Contributor
Author
|
I asked the bug reporter to test this change on Solaris. |
kinkie
approved these changes
Dec 21, 2025
yadij
approved these changes
Dec 22, 2025
squid-anubis
pushed a commit
that referenced
this pull request
Dec 22, 2025
with stub time| FATAL: Ipc::Mem::Segment::create failed to
shm_open(squid-0-tr_rebuild_stats.shm): (22) Invalid argument
Instance::NamePrefix() stub implementation ignored `head` and `tail`
arguments, resulting in malformed shared memory segment names on
Solaris. Other tested OSes tolerate the lack of a leading "/" character.
Linux shm_open(3) recommends "/somename" format "for portable use".
Simply adding `head` and `tail` to `NamePrefix()` result fixes tests on
Solaris but breaks tests on MacOS. We shortened the result (by removing
pid_filename hash component mimicking) to avoid that breakage and
detailed the problem in a C++ comment. More work is needed to replace
human-friendly name components with shorter hashes [on MacOS].
squid-anubis
added
M-waiting-staging-checks
kinkie
added
M-cleared-for-merge
Contributor
|
@rousskov how about shipping it anyway? It should not cause regressions anyway |
Contributor
Author
Your call. I am not violently against merging this without giving the bug reporter more time to test whether this (seemingly safe) fix works on Solaris. Just re-add the |
squid-anubis
pushed a commit
that referenced
this pull request
Dec 23, 2025
with stub time| FATAL: Ipc::Mem::Segment::create failed to
shm_open(squid-0-tr_rebuild_stats.shm): (22) Invalid argument
Instance::NamePrefix() stub implementation ignored `head` and `tail`
arguments, resulting in malformed shared memory segment names on
Solaris. Other tested OSes tolerate the lack of a leading "/" character.
Linux shm_open(3) recommends "/somename" format "for portable use".
Simply adding `head` and `tail` to `NamePrefix()` result fixes tests on
Solaris but breaks tests on MacOS. We shortened the result (by removing
pid_filename hash component mimicking) to avoid that breakage and
detailed the problem in a C++ comment. More work is needed to replace
human-friendly name components with shorter hashes [on MacOS].
squid-anubis
added
M-waiting-staging-checks
kinkie
added
the
M-cleared-for-merge
Contributor
Let's ship it. We can always come back to it if the reporter feeds back it's not working |
squid-anubis
pushed a commit
that referenced
this pull request
Dec 25, 2025
with stub time| FATAL: Ipc::Mem::Segment::create failed to
shm_open(squid-0-tr_rebuild_stats.shm): (22) Invalid argument
Instance::NamePrefix() stub implementation ignored `head` and `tail`
arguments, resulting in malformed shared memory segment names on
Solaris. Other tested OSes tolerate the lack of a leading "/" character.
Linux shm_open(3) recommends "/somename" format "for portable use".
Simply adding `head` and `tail` to `NamePrefix()` result fixes tests on
Solaris but breaks tests on MacOS. We shortened the result (by removing
pid_filename hash component mimicking) to avoid that breakage and
detailed the problem in a C++ comment. More work is needed to replace
human-friendly name components with shorter hashes [on MacOS].
squid-anubis
added
M-waiting-staging-checks
squid-anubis
added
M-merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instance::NamePrefix() stub implementation ignored
headandtailarguments, resulting in malformed shared memory segment names on
Solaris. Other tested OSes tolerate the lack of a leading "/" character.
Linux shm_open(3) recommends "/somename" format "for portable use".
Simply adding
headandtailtoNamePrefix()result fixes tests onSolaris but breaks tests on MacOS. We shortened the result (by removing
pid_filename hash component mimicking) to avoid that breakage and
detailed the problem in a C++ comment. More work is needed to replace
human-friendly name components with shorter hashes [on MacOS].