feat(nix): preliminary desktop app flake integration #6135
+214
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds preliminary Nix flake support for building the Tauri desktop application. The implementation enables building the desktop app through Nix on NixOS and macOS, though it may require additional work for proper UI rendering on other GNU/Linux distributions.
Key Changes:
- Adds
nix/desktop.nixwith a complete Rust/Tauri build pipeline including frontend compilation, sidecar integration, and proper library path handling - Integrates the desktop package into
flake.nixas a new output alongside the existing CLI package - Reformats function parameters in
nix/opencode.nixandnix/node-modules.nixfor consistency
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| nix/desktop.nix | New file implementing the desktop app build derivation with Rust compilation, Node.js frontend build, and platform-specific library linking |
| flake.nix | Adds desktop package instantiation and exposes it as a flake output while restructuring the packages section |
| nix/opencode.nix | Reformats function parameter list to multi-line format for improved readability |
| nix/node-modules.nix | Reformats function parameters and native build inputs list to multi-line format |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Addressed review notes:
|
Collaborator
|
wow thank u |
Collaborator
|
ill send to adam/brendan since they work on desktop |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a preliminary Nix flake package for the Tauri desktop app.
Tested on NixOS and on macOS. On other GNU/Linux distros, it likely needs more work for the UI to render/display correctly (e.g. runtime deps / WebKitGTK setup).