feat: Replace credentials-secret with db/broker connection(s)#743
Open
feat: Replace credentials-secret with db/broker connection(s)#743
Conversation
13 tasks
sbernauer
reviewed
Feb 10, 2026
docs/modules/airflow/examples/getting_started/code/airflow.yaml
Outdated
Show resolved
Hide resolved
docs/modules/airflow/examples/getting_started/code/airflow.yaml
Outdated
Show resolved
Hide resolved
docs/modules/airflow/examples/getting_started/code/airflow.yaml
Outdated
Show resolved
Hide resolved
docs/modules/airflow/examples/getting_started/code/airflow.yaml
Outdated
Show resolved
Hide resolved
maltesander
requested changes
Feb 10, 2026
tests/templates/kuttl/versioning/30-install-airflow-cluster.yaml.j2
Outdated
Show resolved
Hide resolved
Comment on lines
+83
to
+88
| # TODO revert this before merging! | ||
| # - name: logging | ||
| # dimensions: | ||
| # - airflow | ||
| # - openshift | ||
| # - executor |
| uriSecret: redis-celery # <3> | ||
| ---- | ||
|
|
||
| <1> A reference to a secret which must contain the single fields `uri` e.g. |
Member
There was a problem hiding this comment.
I feel URI is very generic. I think connectionString is a better description?
Member
Author
There was a problem hiding this comment.
No strong feelings - I just went with what we had in the decision.
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
…cluster.yaml.j2 Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
…uster.yaml.j2 Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
…ml.j2 Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
…r.yaml.j2 Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
maltesander
reviewed
Feb 10, 2026
Member
maltesander
left a comment
There was a problem hiding this comment.
Some more doc reviews. Tests look good.
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
…l.j2 Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
maltesander
reviewed
Feb 11, 2026
Member
Author
|
Re-ran tests after latest changes 🟢 https://testing.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/airflow-operator-it-custom/77/ |
Member
Author
|
We (me, @sbernauer and @maltesander) discussed this today and decided to move it to tracking. The PR is "finished" in the sense that the implementation is complete, but there are improvements we can make to the code (e.g. using traits) to make it more flexible for other products that will use this.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #64
Decision: https://github.com/stackabletech/decisions/issues/72
Notes for reviewers
database.rs,queue.rsandconnection.rs.$FOO) by processes started from the shell${env:...}and has been written to a config fileenvlibrary is not safe in a multithreaded environmentJenkins 🟢 https://testing.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/airflow-operator-it-custom/75/
Openshift 🟢 https://testing.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/airflow-operator-it-custom/76/
Important
The logging test has been deactivated temporarily while testing this PR. Revert the setting before final approval/merging.
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker