Skip to content

Comments

feat: JupyterHub configuration#715

Merged
adwk67 merged 20 commits intomainfrom
feature/jupyterhub
Mar 10, 2025
Merged

feat: JupyterHub configuration#715
adwk67 merged 20 commits intomainfrom
feature/jupyterhub

Conversation

@adwk67
Copy link
Member

@adwk67 adwk67 commented Feb 28, 2025 •
edited
Loading

@adwk67 adwk67 mentioned this pull request Feb 28, 2025
Merged
@netlify
Copy link

netlify bot commented Feb 28, 2025 •
edited
Loading

✅ Deploy Preview for stackable-docs ready!

Name Link
🔨 Latest commit 07025d1
🔍 Latest deploy log https://app.netlify.com/sites/stackable-docs/deploys/67ceb840c6573c0008104949
😎 Deploy Preview https://deploy-preview-715--stackable-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@adwk67 adwk67 self-assigned this Feb 28, 2025
@adwk67 adwk67 linked an issue Feb 28, 2025 that may be closed by this pull request
SDP support for JupyterHub - Phase I stackabletech/issues#191
Closed
@adwk67 adwk67 marked this pull request as ready for review March 5, 2025 13:56
@adwk67 adwk67 moved this to Development: Waiting for Review in Stackable Engineering Mar 5, 2025
@adwk67 adwk67 requested a review from a team March 5, 2025 15:21
@maltesander maltesander self-requested a review March 7, 2025 10:37
@maltesander maltesander moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Mar 7, 2025
maltesander
maltesander requested changes Mar 7, 2025
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor things.
There are many inconsistencies in terms of capitalization e.g. pod/Pod, keycloak/Keycloak, jupyterhub/JupyterHub.
Can you consolidate that?

adwk67 and others added 4 commits March 10, 2025 09:47
@adwk67 adwk67 requested a review from maltesander March 10, 2025 09:09
maltesander
maltesander requested changes Mar 10, 2025
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more inconsistencies:

  • node / Node (i prefer lowercase)
  • secret class / SecretClass (CRD: prefer upper)
  • python / Python (no strong opinion, would capitalize)
  • job / Job (CRD: prefer upper)
  • secret / Secret (depends i guess...)

adwk67 and others added 2 commits March 10, 2025 10:54
@adwk67 @maltesander
Apply suggestions from code review
ff0d115 
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
@adwk67
consistent caps III
07025d1
maltesander
maltesander approved these changes Mar 10, 2025
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@adwk67 adwk67 added this pull request to the merge queue Mar 10, 2025
Merged via the queue into main with commit 25e8d58 Mar 10, 2025
7 checks passed
@adwk67 adwk67 deleted the feature/jupyterhub branch March 10, 2025 10:31
@adwk67 adwk67 moved this from Development: In Review to Development: Done in Stackable Engineering Mar 10, 2025
@lfrancke lfrancke moved this from Development: Done to Acceptance: In Progress in Stackable Engineering Mar 20, 2025
@lfrancke
Copy link
Member

lfrancke commented Mar 20, 2025

Does any of the Jupyter tickets have a release note snippet? We definitely want to make sure to have a sentence about this.
And: Can you please add a link to the docs here?

@maltesander
Copy link
Member

maltesander commented Mar 20, 2025 •
edited by adwk67
Loading

Docs: https://docs.stackable.tech/home/nightly/demos/jupyterhub-keycloak/
Also: https://docs.stackable.tech/home/nightly/tutorials/jupyterhub/

Snippet proposal (@adwk67 pls improve):

The following demo has been added to stackablectl:

JupyterHub-Keycloak

The JupyterHub-Keycloak integration demo offers a comprehensive and secure multi-user data science environment on Kubernetes, integrating Single Sign-on Jupyter notebooks with Stackable Spark and S3 storage.

(@adwk67: just made minor changes plus the tutorial link)

@adwk67 adwk67 mentioned this pull request Mar 26, 2025
Merged
@lfrancke lfrancke moved this from Acceptance: In Progress to Done in Stackable Engineering Mar 26, 2025
@lfrancke lfrancke added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maltesander maltesander maltesander approved these changes

Assignees

@adwk67 adwk67

Labels

release/25.3.0 release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

Stackable Engineering
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SDP support for JupyterHub - Phase I

3 participants

@adwk67 @lfrancke @maltesander