Skip to content

chore: remove unused RBAC role #914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
razvan merged 2 commits into from
Nov 17, 2025
Merged

chore: remove unused RBAC role #914

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
331621c
chore: remove unused RBAC role
razvan Nov 17, 2025
b719508
update changelog
razvan Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,12 @@ All notable changes to this project will be documented in this file.

- Refactor: move server configuration properties from the command line to configuration files. ([#911]).

### Removed

- Refactor: remove unused RBAC cluster role ([#914]).

[#911]: https://github.com/stackabletech/kafka-operator/pull/911
[#914]: https://github.com/stackabletech/kafka-operator/pull/914

## [25.11.0] - 2025-11-07

Expand Down
2 changes: 0 additions & 2 deletions deploy/helm/kafka-operator/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,6 @@ spec:
value: {{ .Values.kubernetesClusterDomain | quote }}
{{- end }}
{{- include "telemetry.envVars" . | nindent 12 }}
- name: KAFKA_BROKER_CLUSTERROLE
value: {{ include "operator.fullname" . }}-kafka-broker-clusterrole
volumes:
- name: config-spec
configMap:
Expand Down
5 changes: 0 additions & 5 deletions deploy/helm/kafka-operator/templates/roles-kafka.yaml
View file
Open in desktop

This file was deleted.

6 changes: 0 additions & 6 deletions rust/operator-binary/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,6 @@ struct Opts {

#[derive(clap::Parser)]
struct KafkaRun {
#[clap(long, env)]
kafka_broker_clusterrole: String,
#[clap(flatten)]
common: RunArguments,
}
Expand Down Expand Up @@ -198,10 +196,6 @@ async fn main() -> anyhow::Result<()> {
Ok(())
}

pub struct ControllerConfig {
pub broker_clusterrole: String,
}

fn references_config_map(
kafka: &DeserializeGuard<v1alpha1::KafkaCluster>,
config_map: &DeserializeGuard<ConfigMap>,
Expand Down