Skip to content

Conversation

@sbernauer
Copy link
Member

@sbernauer sbernauer commented Sep 24, 2025

Description

Part of stackabletech/issues#764.

The server TLS truststore handling was actually fine and left as-is. Only LDAP and OIDC ca cert handling was affected.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@sbernauer
Copy link
Member Author

@sbernauer sbernauer requested review from a team and adwk67 September 24, 2025 13:52
@sbernauer sbernauer self-assigned this Sep 24, 2025
@sbernauer sbernauer moved this to Development: Waiting for Review in Stackable Engineering Sep 24, 2025
@adwk67 adwk67 moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Sep 24, 2025
@adwk67 adwk67 removed the request for review from a team September 24, 2025 13:55
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - re-ran the two failed tests locally and both were 🟢 once the images had been pulled, so we probably have a timeout problem.

Suggestion: raise the timeout for the nifi cluster assert in the external-access test to 1200 (like the ldap test).

@sbernauer
Copy link
Member Author

Raised the timeouts in 8c33023

@sbernauer sbernauer requested a review from adwk67 September 25, 2025 04:32
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sbernauer sbernauer added this pull request to the merge queue Sep 25, 2025
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Sep 25, 2025
Merged via the queue into main with commit 6f84bb1 Sep 25, 2025
17 checks passed
@sbernauer sbernauer deleted the fix/certificate-handling branch September 25, 2025 08:16
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants