Conversation
- Fix all 16 clippy warnings: empty line after attr, let-and-return, needless borrows, uninlined format args, clone-on-copy, module inception, enum variant names, too-many-arguments - Add DSN resolution to SQLDriverConnectW so connection strings with DSN= (but no Database=) resolve the database path from odbc.ini - Extract impl_connect_to_database for direct database path connections, avoiding double DSN lookup when called from SQLDriverConnectW - Untrack .claude/settings.local.json (already in .gitignore) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Replace 3 .unwrap() calls in FFI functions with proper error handling that returns SqlReturn::ERROR instead of panicking the host application - Change allocate_stmt_handle to return Option<StatementHandle> so callers handle missing connections gracefully - Implement SQLDescribeColW with column name (UTF-16), type (SQL_VARCHAR), size (255), decimal digits (0), and nullability (SQL_NULLABLE) - Enable `wide` feature on odbc-api dev-dependency for proper Unicode ODBC client testing - Add test_describe_columns integration test Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Per ODBC spec, SQL_INVALID_HANDLE should be returned when a handle
argument is invalid (null, wrong type, or corrupted tag). Previously
8 of 16 call sites incorrectly returned SQL_ERROR instead.
Also normalizes error messages to the consistent pattern:
error!("Failed to get {handle_type} handle: {}", err)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added SqlDescribeColW, remove unwraps from FFI code, consistent error handling.