Skip to content

fix: Set the issuer in generated TLS certificates to the subject of the issuing certificate #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
siegfriedweber merged 3 commits into from
Mar 6, 2025
Merged

fix: Set the issuer in generated TLS certificates to the subject of the issuing certificate #566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8382a86
fix: Set the issuer in generated TLS certificates to the subject of t…
siegfriedweber Feb 28, 2025
1802a4e
Merge branch 'main' into fix/tls-cert-issuer
siegfriedweber Mar 3, 2025
a75bf8d
Merge branch 'main' into fix/tls-cert-issuer
siegfriedweber Mar 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ All notable changes to this project will be documented in this file.
### Fixed

- Underscores are now allowed in Kerberos principal names ([#563]).
- The issuer in generated TLS certificates is set to the subject of the issuing
certificate ([#566]).

[#528]: https://github.com/stackabletech/secret-operator/pull/528
[#544]: https://github.com/stackabletech/secret-operator/pull/544
Expand All @@ -32,6 +34,7 @@ All notable changes to this project will be documented in this file.
[#552]: https://github.com/stackabletech/secret-operator/pull/552
[#563]: https://github.com/stackabletech/secret-operator/pull/563
[#564]: https://github.com/stackabletech/secret-operator/pull/564
[#566]: https://github.com/stackabletech/secret-operator/pull/566
[#569]: https://github.com/stackabletech/secret-operator/pull/569

## [24.11.1] - 2025-01-10
Expand Down
2 changes: 1 addition & 1 deletion rust/operator-binary/src/backend/tls/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ impl SecretBackend for TlsGenerate {
})?
.build();
x509.set_subject_name(&subject_name)?;
x509.set_issuer_name(ca.certificate.issuer_name())?;
x509.set_issuer_name(ca.certificate.subject_name())?;
x509.set_not_before(Asn1Time::from_unix(not_before.unix_timestamp())?.as_ref())?;
x509.set_not_after(Asn1Time::from_unix(not_after.unix_timestamp())?.as_ref())?;
x509.set_pubkey(&pod_key)?;
Expand Down
Loading