Skip to content

Conversation

@siegfriedweber
Copy link
Member

Description

Fix the k8sSearch example.

The Pod specification was invalid and the label secrets.stackable.tech/pod on the Secret was missing.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@siegfriedweber siegfriedweber requested a review from a team March 3, 2025 14:54
@siegfriedweber siegfriedweber self-assigned this Mar 3, 2025
@siegfriedweber siegfriedweber moved this to Development: Waiting for Review in Stackable Engineering Mar 3, 2025
@siegfriedweber siegfriedweber force-pushed the doc/fix-k8s-search-example branch from 62c442d to f6946a2 Compare March 3, 2025 14:55
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sbernauer sbernauer moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Mar 3, 2025
@siegfriedweber siegfriedweber added this pull request to the merge queue Mar 3, 2025
@siegfriedweber siegfriedweber moved this from Development: In Review to Development: Done in Stackable Engineering Mar 3, 2025
Merged via the queue into main with commit 6685eba Mar 3, 2025
14 of 16 checks passed
@siegfriedweber siegfriedweber deleted the doc/fix-k8s-search-example branch March 3, 2025 15:15
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants