Skip to content

Conversation

@adwk67
Copy link
Member

@adwk67 adwk67 commented Mar 11, 2025

Description

Fixes #559
From that issue:

We should pull the current KVNO from LDAP: serverfault.com/a/869870/88628

Implemented in this PR.

Ideally we should associate each cache entry with its KVNO rather than pulling the current KVNO at keytab-building-time.

Not yet implemented, as I couldn't think of a clean way to integrate it with the existing CredentialCache. But open to suggestions :)

Tests 🟢

--- PASS: kuttl (23.91s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/kerberos-ad_krb5-1.21.1_ad-custom-samaccountname-false (23.72s)
        --- PASS: kuttl/harness/kerberos-ad_krb5-1.21.1_ad-custom-samaccountname-true (23.77s)
PASS

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [x] Helm chart can be installed and deployed operator works
- [x] Integration tests passed (for non trivial changes)
- [x] Changes need to be "offline" compatible
# Reviewer
- [x] Code contains useful comments
- [x] Code contains useful logging statements
- [x] Changelog updated
- [x] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@adwk67 adwk67 requested a review from siegfriedweber March 12, 2025 07:45
@adwk67 adwk67 self-assigned this Mar 12, 2025
@adwk67 adwk67 marked this pull request as ready for review March 12, 2025 16:28
@adwk67 adwk67 moved this to Development: In Review in Stackable Engineering Mar 14, 2025
@adwk67 adwk67 added this pull request to the merge queue Mar 14, 2025
Merged via the queue into main with commit 12d0b17 Mar 14, 2025
16 of 17 checks passed
@adwk67 adwk67 deleted the fix/kvno-lookup branch March 14, 2025 13:14
@adwk67 adwk67 moved this from Development: In Review to Development: Done in Stackable Engineering Mar 14, 2025
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

kerberos (AD): kvno is hardcoded as 0

4 participants