Skip to content

chore!: Bind to IPv4 only #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbernauer merged 2 commits into from
Sep 15, 2025
Merged

chore!: Bind to IPv4 only #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9d17a5
chore!: Bind to IPv4 only
sbernauer Sep 15, 2025
72b7eaf
changelog
sbernauer Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ All notable changes to this project will be documented in this file.
- The Stackable scaler now ensures that a `TrinoCluster` has changed to `ready` more than 5 seconds
ago before marking it as `ready` ([#68]).
- Emit less attributes in tracing to make logs easier readable ([#86]).
- BREAKING: Only bind to IPv4 (`0.0.0.0`) instead of IPv6 (`::`).
On most Linux systems, binding to `::` dual-stacks, on Windows this would likely bind to IPv6 only.
As a user reported that they run into `Address family not supported by protocol (os error 97)`, we now only bind to IPv4.
There was some attempt to make it portable work on IPv4 and IPv6 (optional), but that turned out to be a bigger story for later ([#91]).

### Fixed

Expand All @@ -17,6 +21,7 @@ All notable changes to this project will be documented in this file.
[#68]: https://github.com/stackabletech/trino-lb/pull/68
[#85]: https://github.com/stackabletech/trino-lb/pull/85
[#86]: https://github.com/stackabletech/trino-lb/pull/86
[#91]: https://github.com/stackabletech/trino-lb/pull/91

## [0.5.0] - 2025-03-14

Expand Down
8 changes: 4 additions & 4 deletions trino-lb/src/http_server/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
use std::{
fmt::Debug,
net::{Ipv6Addr, SocketAddr},
net::{Ipv4Addr, SocketAddr},
path::PathBuf,
sync::Arc,
time::Duration,
Expand Down Expand Up @@ -77,7 +77,7 @@ pub async fn start_http_server(
.route("/", get(|| async { Redirect::permanent("/metrics") }))
.route("/metrics", get(metrics::get))
.with_state(Arc::clone(&app_state));
let listen_addr = SocketAddr::from((Ipv6Addr::UNSPECIFIED, ports_config.metrics));
let listen_addr = SocketAddr::from((Ipv4Addr::UNSPECIFIED, ports_config.metrics));
info!(%listen_addr, "Starting metrics exporter");

let handle = Handle::new();
Expand Down Expand Up @@ -129,7 +129,7 @@ pub async fn start_http_server(

if tls_config.enabled {
// Start https server
let listen_addr = SocketAddr::from((Ipv6Addr::UNSPECIFIED, ports_config.https));
let listen_addr = SocketAddr::from((Ipv4Addr::UNSPECIFIED, ports_config.https));
info!(%listen_addr, "Starting server");

let cert_pem_file = tls_config.cert_pem_file.context(CertsMissingSnafu)?;
Expand All @@ -148,7 +148,7 @@ pub async fn start_http_server(
.context(StartHttpServerSnafu)?;
} else {
// Start http server
let listen_addr = SocketAddr::from((Ipv6Addr::UNSPECIFIED, ports_config.http));
let listen_addr = SocketAddr::from((Ipv4Addr::UNSPECIFIED, ports_config.http));
info!(%listen_addr, "Starting server");

axum_server::bind(listen_addr)
Expand Down
Loading