-
-
Notifications
You must be signed in to change notification settings - Fork 8
feat: Support for fault-tolerant execution #779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4cc640f to
3d113df
Compare
fc684e3 to
85a09cc
Compare
sbernauer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dropped some comments on the CRD code and YAML.
As an possible alternative I can propose a complex enum style, where we can together think about it, just pasting it here for reference for now
spec:
clusterConfig:
faultTolerantExecution:
query:
retryAttempts: 4 # maps to query-retry-attempts
retryInitialDelay: 10s
retryMaxDelay: 60s
retryDelayScaleFactor: 2.0 # f32
exchangeManager: # Optional
deduplicationBufferSize: 64Mi # Quantity
encryptionEnabled: true
sinkBufferPoolMinSize: 20
sinkBuffersPerPartition: 4
sinkMaxFileSize: 2Gi # Quantity
sourceConcurrentReaders: 8
s3:
baseDirectories:
- s3://trino-exchange-bucket/spooling
connection: # Mandatory
reference: minio-connection
maxErrorRetries: 10
uploadPartSize: 10Mi # Quantity
# OR
task:
retryAttemptsPerTask: 4 # maps to task-retry-attempts-per-task
retryInitialDelay: 10s
retryMaxDelay: 60s
retryDelayScaleFactor: 2.0 # f32
exchangeManager: # Mandatory
# ... same struct as above
docs/modules/trino/pages/usage-guide/fault-tolerant-execution.adoc
Outdated
Show resolved
Hide resolved
docs/modules/trino/pages/usage-guide/fault-tolerant-execution.adoc
Outdated
Show resolved
Hide resolved
docs/modules/trino/pages/usage-guide/fault-tolerant-execution.adoc
Outdated
Show resolved
Hide resolved
docs/modules/trino/pages/usage-guide/fault-tolerant-execution.adoc
Outdated
Show resolved
Hide resolved
tests/templates/kuttl/fault-tolerant-execution/helm-bitnami-minio-values.yaml
Show resolved
Hide resolved
2567920 to
843b18d
Compare
fd42c2b to
af39e6b
Compare
eaaff12 to
9e587d8
Compare
…adoc Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
539473f to
b9f5ca9
Compare
docs/modules/trino/pages/usage-guide/fault-tolerant-execution.adoc
Outdated
Show resolved
Hide resolved
docs/modules/trino/pages/usage-guide/fault-tolerant-execution.adoc
Outdated
Show resolved
Hide resolved
docs/modules/trino/pages/usage-guide/fault-tolerant-execution.adoc
Outdated
Show resolved
Hide resolved
docs/modules/trino/pages/usage-guide/fault-tolerant-execution.adoc
Outdated
Show resolved
Hide resolved
tests/templates/kuttl/fault-tolerant-execution/05-run-tests.yaml
Outdated
Show resolved
Hide resolved
…adoc Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
…adoc Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
…adoc Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
…adoc Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
maltesander
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Release noteSDP now supports configuring fault-tolerant execution for Trino via the TrinoCluster CRD |
|
Are there any docs for this we can link to? |
Description
Implementation for #576
When providing credentials for S3, Azure or GCS we currently need a
SecretClass. It would be easier if the user could just provide aSecretas an alternative, we had that discussion recently. To be consistent with the current state, I usedSecretClassexclusively for now.Things I did not do in this PR to ease the review process (we could tackle those as a separate PR):
load_env_from_filesstuntDefinition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker