Open
Conversation
smnh
requested changes
Aug 10, 2021
Comment on lines
+381
to
+385
| async getStaticPages() { | ||
| const data = await this.getData(); | ||
| let paths = _.map(data.pages, (page) => page); | ||
| return paths; | ||
| } |
Member
There was a problem hiding this comment.
@JugglerX isn't the path variable should be pages?
And also, why not:
async getStaticPages() {
const data = await this.getData();
return data.pages;
}And if are already there, do we really need this low resolution helper methods?
Wouldn't calling sourcebitDataClient.getData().pages be enough?
Comment on lines
-384
to
-386
| if (process.env.NODE_ENV === 'development') { | ||
| paths = paths.concat(_.map(paths, (pagePath) => pagePath + (pagePath !== '/' ? '/' : ''))); | ||
| } |
| "react": ">=16", | ||
| "next": "10.x" | ||
| "react": ">=17", | ||
| "next": "^11.0.0" |
Member
There was a problem hiding this comment.
@JugglerX we have existing projects that use sourcebit and are running under next 10.
So I suggest making it ">=10"
Member
There was a problem hiding this comment.
Suggested change
| "next": "^11.0.0" | |
| "next": ">=10" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.