Hull classifiers to antennas #118
Conversation
.gitignore
Outdated
There was a problem hiding this comment.
What file were you working with that had this extension?
There was a problem hiding this comment.
*bak is how I marked the backups.
There was a problem hiding this comment.
Which backups are you referring to? So with git, you never need to save backups of files that have already been committed to the tree, because they're always available through the commit history. You can check out any version of any file from any time it's been committed.
The gitignore is meant to include all files that should everyone working on this project would want to ignore - so we only include file types that are directly correlated with the body of code. Personal preferences we leave to the global .gitignore file (likely already available in your ~ directory).
This isn't to be a dick, it's just long term better practice to be semantic about what we include to help describe the project and ensure no one is ever surprised because they try to add a legitimate file but it's ignored due to an unfamiliar ignore.
There was a problem hiding this comment.
Understood :) Thanks for the clarification, I've never used github before, so I am still new to the practices.
Will move this to my global .gitignore Sorry for cluttering the file, I thought it influences my github only.
*.bak is how I use Notepad++ to quickly test an idea without involving repositories. I just copy a file to *.bak, and then test ideas by changing the original file and seeing the effect. Reverting is faster than with git.
|
For the attachment points, not sure how I feel about allowing it to attach everywhere. Our new model is designed with the lower half attachment points in mind and would not actually be touching on top. Plus I think limited attachment points is an interesting building dynamic. Could you please revert those changes? We can open an issue to discuss if this is something we need if you feel strongly about it. |
|
I will open an issue to discuss: #119 Not touching on top could lead to breaking existing designs. |
|
Looking good, please fix the |
|
Removed my stuff from the .gitignore |
…er to 100%, disables gyro overrides The "/gc fleet stop" command enables thrusters, also enables gyroscopes, sets their power to 100%, and disables their overrides. This was added because the command failed to stop ships on the server if their thrusters were turned off.
|
Per our convo, please rebase to master. |
Added <ResourceSinkGroup>Utility</ResourceSinkGroup> to every Hull Classifier definition
…er to 100%, disables gyro overrides The "/gc fleet stop" command enables thrusters, also enables gyroscopes, sets their power to 100%, and disables their overrides. This was added because the command failed to stop ships on the server if their thrusters were turned off.
Added <ResourceSinkGroup>Utility</ResourceSinkGroup> to every Hull Classifier definition
2 participants
Hull classifiers changed to be antennas and not beacons. This removes the annoying glow and allows to turn broadcasting off without turning off the classifier itself.
Downsides: consumes more power, may be hacked in the Autpilot/Radar metagame and give away ships/bases locations to enemy.
Will look for a way to make the default beacons non-glowing and, if possible, separate the broadcasting feature from turning the block on/off. Will try to decrease the new "antenna" classifiers power consumption.
All the surfaces of beacons and hull classifiers made mountable to prevent problems with building (for more convenient building).