Skip to content

Conversation

@priteau
Copy link
Member

@priteau priteau commented Jan 13, 2026

This should resolve SSH issues with some modern key types such as ed25519.

@priteau priteau self-assigned this Jan 13, 2026
@priteau priteau requested a review from a team as a code owner January 13, 2026 22:51
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly reverts the RHEL 9 crypto policy from FIPS to DEFAULT to allow the use of modern SSH key types like ed25519. The change is well-documented with a new comment and a release note.

However, for this change to be fully effective, a related modification is required in a file not included in this PR's changes. The file etc/kayobe/ansible/maintenance/cis.yml contains an Ansible assertion that explicitly blocks the use of ed25519 keys on Red Hat systems. This assertion was relevant for the FIPS policy but now contradicts the goal of this PR. It should be removed to prevent failures for users who wish to use ed25519 keys.

I've also added one suggestion to improve the clarity of comments in the configuration file.

mnasiadka
mnasiadka previously approved these changes Jan 14, 2026
This should resolve SSH issues with some modern key types such as
ed25519.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants