Skip to content

Conversation

@priteau
Copy link
Member

@priteau priteau commented Jan 15, 2026

This should resolve SSH issues with some modern key types such as ed25519.

(cherry picked from commit f4b85ef)

@priteau priteau self-assigned this Jan 15, 2026
@priteau priteau requested a review from a team as a code owner January 15, 2026 17:39
This should resolve SSH issues with some modern key types such as
ed25519.

(cherry picked from commit f4b85ef)
@priteau priteau force-pushed the rhel9cis-crypto-policy-ci-antelope branch from 128b6b2 to 6245b85 Compare January 15, 2026 17:40
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the CI configuration to set the RHEL 9 crypto policy to DEFAULT, which resolves issues with ed25519 SSH keys. This is achieved by adding environment-specific group variables for ci-aio and ci-multinode to override the default FIPS policy. The Ansible playbook for CIS hardening is also updated to only check for unsupported key types when the FIPS policy is active. The changes are logical and address the issue described. I've left one comment regarding duplicated configuration between the CI environments, suggesting a possible improvement for future maintainability.

I am having trouble creating individual review comments. Click here to see my feedback.

etc/kayobe/environments/ci-multinode/inventory/group_vars/cis-hardening/cis (1-21)

medium

This file is identical to etc/kayobe/environments/ci-aio/inventory/group_vars/cis-hardening/cis. To avoid duplication and ensure consistency, consider creating a common set of CI group variables that can be shared between the ci-aio and ci-multinode environments. For example, you could define a common inventory group for CI and place these variables there. This would make future maintenance easier as changes would only need to be made in one place.

@priteau priteau changed the title CI: Set RL9 crypto policy to DEFAULT CI: Set RL9 crypto policy to DEFAULT (Antelope) Jan 15, 2026
@priteau priteau merged commit 347c149 into stackhpc/2023.1 Jan 16, 2026
10 of 12 checks passed
@priteau priteau deleted the rhel9cis-crypto-policy-ci-antelope branch January 16, 2026 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants