add arista bond with trunk support #2091
Open
+12
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to get [1] [1] https://review.opendev.org/c/openstack/networking-generic-switch/+/973461 Signed-off-by: Bartosz Bezak <bartosz@stackhpc.com>
Signed-off-by: Bartosz Bezak <bartosz@stackhpc.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds support for Arista bond interfaces with trunk mode by incorporating a fork of networking-generic-switch. The changes include adding a new Neutron image tag, updating Kolla sources to point to the forked repository, and creating a corresponding release note. The changes are logical and align with the stated goal. I have one suggestion to improve code maintainability regarding the ordering of items in a YAML mapping.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding NGS fork to get arista bond with trunk support
https://review.opendev.org/c/openstack/networking-generic-switch/+/973461