feat: add project validation (only for service SKE yet) #1000
Closed
feat: add project validation (only for service SKE yet) #1000
Conversation
rubenhoenle
reviewed
Sep 25, 2025
rubenhoenle
reviewed
Sep 25, 2025
| return err | ||
| } | ||
|
|
||
| // Validate project ID (exists and user has access) |
Member
There was a problem hiding this comment.
Didn't we agree in the refinement that we want to reduce boilerplate code within the implementation of this story? Instead we'll now have even more of it with your current approach.
marceljk
reviewed
Sep 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change implements validation checks for the project ID, project existence, and user access rights. It also simplifies the project label retrieval logic by reducing boilerplate code.
Jira-Ticket: https://jira.schwarz/browse/STACKITCLI-61
Checklist
make fmtmake generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)